zhannngchen commented on code in PR #18686:
URL: https://github.com/apache/doris/pull/18686#discussion_r1169577868
##########
be/src/olap/memtable.cpp:
##########
@@ -191,8 +191,8 @@ void MemTable::_insert_one_row_from_block(RowInBlock*
row_in_block) {
_rows++;
bool overwritten = false;
if (_keys_type == KeysType::DUP_KEYS) {
- // TODO: dup keys only need sort opertaion. Rethink skiplist is the
beat way to sort columns?
- _vec_skip_list->Insert(row_in_block, &overwritten);
+ // dup keys only need sort operation, use vector to sort is faster
than skiplist
+ _vec_row.emplace_back(row_in_block);
Review Comment:
reserve space at `insert` will be faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
