zhannngchen commented on code in PR #18686:
URL: https://github.com/apache/doris/pull/18686#discussion_r1169566576
##########
be/src/olap/memtable.cpp:
##########
@@ -243,11 +243,16 @@ void MemTable::_collect_vskiplist_results() {
VecTable::Iterator it(_vec_skip_list.get());
vectorized::Block in_block = _input_mutable_block.to_block();
if (_keys_type == KeysType::DUP_KEYS) {
+ RowComparator _cmp(_schema);
+ vectorized::MutableBlock mutable_block =
+ vectorized::MutableBlock::build_mutable_block(&in_block);
+ _cmp.set_block(&mutable_block);
+ std::sort(_vec_row.begin(), _vec_row.end(), _cmp);
Review Comment:
you can use the `_vec_row_comparator` with lambda directly, like this way:
```
std::sort(_vec_row.begin(), _vec_row.end(),
[this](const RowInBlock* l, const RowInBlock* r) -> bool {
return (*(this->_vec_row_comparator))(l, r) < 0;
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
