yujun777 commented on code in PR #70480:
URL: https://github.com/apache/doris/pull/70480#discussion_r4639613063


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPruner.java:
##########
@@ -33,6 +34,7 @@
 import org.apache.doris.nereids.trees.plans.physical.PhysicalIntersect;
 import org.apache.doris.nereids.trees.plans.physical.PhysicalLimit;

Review Comment:
   The existing `test_olap_table_stream_mixed_history_incremental` fixture can 
reproduce this plan shape. It writes to `p1` before creating the stream with 
`show_initial_rows=true`, then writes to `p2` afterward. Could you reuse that 
fixture and add an `EXPLAIN` assertion for a broadcast hash join with the 
stream on the build side? Joining on a probe column that cannot prune 
partitions or buckets would let the assertion catch whether the changelog 
marker reaches the top of the `UNION ALL` and keeps the probe runtime filter.
   
   [Existing mixed history/incremental 
fixture](https://github.com/apache/doris/blob/968bef8cb315f914cedb7bdc3034c2dcee438a94/regression-test/suites/table_stream_p0/test_olap_table_stream_mixed_history_incremental.groovy#L27-L62)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to