github-actions[bot] commented on code in PR #70480:
URL: https://github.com/apache/doris/pull/70480#discussion_r4639106254


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPruner.java:
##########
@@ -33,6 +34,7 @@
 import org.apache.doris.nereids.trees.plans.physical.PhysicalIntersect;
 import org.apache.doris.nereids.trees.plans.physical.PhysicalLimit;

Review Comment:
   [P2] Propagate changelog effectiveness through mixed stream UNIONs
   
   A normal table-stream read can contain both a historical base-table branch 
and an incremental `OlapChangelogTableWrapper` branch; 
`NormalizeOlapTableStreamScan` combines these into a `PhysicalUnion` (snapshot 
rebuilds do the same). `RuntimeFilterPruner.visitPhysicalSetOperation` only 
visits the children, so the new `NATIVE` marker stops at the changelog child 
and `join.right()` remains ineffective. When the stream is the build side of a 
hash join with unknown or non-selective stats, `visitPhysicalHashJoin` 
therefore removes the probe runtime filter even though part of the build input 
is incremental data whose stats are not represented by the base table. 
Propagate the effective source through the set operation with the appropriate 
type semantics and add a mixed history/incremental regression case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to