HappenLee commented on code in PR #70073:
URL: https://github.com/apache/doris/pull/70073#discussion_r4609072158


##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -535,11 +535,14 @@ struct TQueryOptions {
 
   // FE can explicitly and idempotently acknowledge external-file commit 
reports.
   236: optional bool supports_external_file_report_ack = false;
-  // Memory limit for one non-streaming analytic partition before it 
proactively spills.
-  237: optional i64 spill_analytic_sink_mem_limit_bytes = 67108864;
+  // Keep field 237 aligned with branch-4.1 Paimon BLOB query options.
+  237: optional i64 paimon_blob_max_size = 10485760;

Review Comment:
   This change is intentional: field 237 must remain `paimon_blob_max_size` to 
preserve compatibility with older branch-4.1 builds, which already use that 
wire ID for the BLOB limit. Keeping master's spill assignment at 237 would 
instead decode the old branch-4.1 BLOB option as a spill limit. That is why 
this PR keeps BLOB at 237 and moves the conflicting spill option to the unused 
field 240.
   
   The compatibility target is the existing branch-4.1 BLOB protocol. The older 
master spill schema has a conflicting meaning for the same `i64` field; 
preserving both meanings across arbitrary mixed FE/BE versions would require an 
explicit version discriminator. The matching-build requirement for those older 
master builds is already documented in the release note. This is an intentional 
protocol alignment to preserve the older branch-4.1 assignment, with that 
compatibility boundary acknowledged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to