github-actions[bot] commented on code in PR #70073:
URL: https://github.com/apache/doris/pull/70073#discussion_r4608869183


##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -535,11 +535,14 @@ struct TQueryOptions {
 
   // FE can explicitly and idempotently acknowledge external-file commit 
reports.
   236: optional bool supports_external_file_report_ack = false;
-  // Memory limit for one non-streaming analytic partition before it 
proactively spills.
-  237: optional i64 spill_analytic_sink_mem_limit_bytes = 67108864;
+  // Keep field 237 aligned with branch-4.1 Paimon BLOB query options.
+  237: optional i64 paimon_blob_max_size = 10485760;

Review Comment:
   [P1] Preserve the spill limit across mixed FE/BE versions
   
   Field 237 is already `spill_analytic_sink_mem_limit_bytes` on the PR base 
and current master. Replacing it with another `i64` and moving spill to 240 
silently loses configured spill limits in either rolling-upgrade order: an old 
FE sends `SET spill_analytic_sink_mem_limit_bytes=1048576` at 237, which a new 
BE decodes as the BLOB option; a new FE sends it at 240, which an old BE skips. 
In both cases `RuntimeState::spill_analytic_sink_mem_limit_bytes()` sees its 
spill field unset and returns 64 MiB, changing proactive spilling and 
reservation sizing. `SessionVariable.toThrift()` forwards this option without 
peer-version discrimination. The matching-build release note does not provide a 
compatibility gate. Preserve the allocated wire meaning or implement an 
explicit migration that disambiguates the existing branch conflict and retains 
non-default limits in both directions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to