yiguolei commented on code in PR #69635:
URL: https://github.com/apache/doris/pull/69635#discussion_r4533839342


##########
be/src/exec/spill/spill_file.h:
##########
@@ -62,6 +66,8 @@ class SpillFile : public 
std::enable_shared_from_this<SpillFile> {
     /// @param data_dir       The spill storage directory (disk) selected by 
SpillFileManager.
     /// @param relative_path  Relative path under the spill root, formatted by 
the operator.
     ///                       e.g. "query_id/sort-node_id-task_id-unique_id"
+    SpillFile(SpillDataDir* data_dir, io::FileSystemSPtr fs, std::string 
relative_path);

Review Comment:
   maybe we can use options.backend_uid = doris::UniqueId::gen_uid(); as remote 
dir path and local path. So that we do not need move dir to gc path now. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to