yiguolei commented on code in PR #69635:
URL: https://github.com/apache/doris/pull/69635#discussion_r4533760363
##########
be/src/exec/spill/spill_file_manager.cpp:
##########
@@ -135,15 +181,32 @@ void ExternalSpillSession::update_accounting(const
std::string& path, int64_t cu
SpillFileManager::~SpillFileManager() {
// QueryContext destruction can still queue failed deletions after stop(),
for example while
// VDataStreamMgr is being destroyed. Retry them once more before dropping
the in-memory state.
- // Any directory that still cannot be deleted remains under the active
spill root and will be
- // moved to the GC root by init() after restart.
- _retry_pending_query_spill_directories();
Review Comment:
在析构代码里执行这个操作是不对的。这样会知道我们优雅重启，滚动升级的时候变慢，析构里不要做这种重操作。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
