morningman commented on PR #67899: URL: https://github.com/apache/doris/pull/67899#issuecomment-6545377625
@hutiefang76 I pushed 747a1d46660 on top of your branch for the round-3 review finding (thread r4430787448). GetTables no longer passes its first requested type to `listTableStatus`, so a VIEW-only request now lists every object, and on a non-master FE in cloud mode the service refreshed each OLAP table's partition versions from the meta service before listing it, whatever columns were requested. When that RPC failed, the listing stopped at that table and the request still succeeded, without that table and everything after it. The refresh now runs only when `UPDATE_TIME` is requested, the one column that reads those versions, so GetTables (names and types) no longer depends on it, and `information_schema.tables` scans that read `UPDATE_TIME` refresh as before. This brings `service/FrontendServiceImpl.java` and `FrontendServiceImplTest` into the PR. Local results on 747a1d46660: `FrontendServiceImplTest` (30), `FlightSqlSchemaHelperTableTypesTest` (27), `DorisFlightSqlProducerTest` (12), `FlightSqlTableTypesTest` (3), `FlightSqlSchemaHelperSerializedSchemaTest` (3) and `FlightSqlNativeVariantTest` (3) pass, and FE Checkstyle reports 0 violations. With the new condition removed, only the new test fails: the name/type listing comes back empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
