github-actions[bot] commented on code in PR #67899:
URL: https://github.com/apache/doris/pull/67899#discussion_r4430787448
##########
fe/fe-core/src/main/java/org/apache/doris/arrowflight/FlightSqlSchemaHelper.java:
##########
@@ -333,12 +374,21 @@ public void getTables(VectorSchemaRoot vectorSchemaRoot)
throws TException {
for (int dbIndex = 0; dbIndex < getDbsResult.getDbs().size();
dbIndex++) {
String dbName = getDbsResult.getDbs().get(dbIndex);
String catalogName = getDbsResult.isSetCatalogs() ?
getDbsResult.getCatalogs().get(dbIndex) : "";
- TListTableStatusResult listTableStatusResult =
listTableStatus(dbName, catalogName);
+ List<TTableStatus> tables = listTableStatus(dbName,
catalogName).getTables();
Review Comment:
[P2] Keep VIEW-only listings independent of OLAP version RPCs
After removing `setType("VIEW")`, a `GetTables` request filtered to `VIEW`
also enumerates matching OLAP tables. On a cloud follower,
`FrontendServiceImpl.listTableStatus` calls
`CloudPartition.getSnapshotVisibleVersion` even for this name/type-only
projection. With an expired cache, an MS RPC failure is caught around the
entire enumeration and returns only the accumulated prefix. If that base table
precedes a view, the view is silently missing although it needs no partition
version; the previous VIEW-only path never visited the base table. Skip the
version refresh for this projection, or apply the canonical type predicate
before that work, and cover this cloud-follower failure case using the real
service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
