yujun777 commented on code in PR #69851:
URL: https://github.com/apache/doris/pull/69851#discussion_r4422125363
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionUtil.java:
##########
@@ -751,6 +751,31 @@ public static Type
getPartitionColumnType(MTMVRelatedTableIf relatedTable, Strin
throw new AnalysisException("can not getPartitionColumnType by:" +
col);
}
+ /**
+ * The base partitions that a refresh of the given MV partitions resets,
per table the MV is
+ * partitioned by: every base partition the partition mapping names for
them.
+ */
+ public static Map<BaseTableInfo, Set<Long>> collectPctResetPartitionIds(
Review Comment:
No longer applicable after 3daed42. That comment was made against 96e86d6,
where the helper had been moved out of `MTMVTask`; the final revision does not
move it — `MTMVTask.collectPctResetPartitionIds` and `MTMVPartitionUtil` are
unchanged from master, so
`MTMVTaskTest#testCollectPctResetPartitionIdsSupportsMultiplePctTables` still
resolves the private method. Verified locally on 3daed42: the test passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
