github-actions[bot] commented on code in PR #69851:
URL: https://github.com/apache/doris/pull/69851#discussion_r4419918210
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionUtil.java:
##########
@@ -751,6 +751,31 @@ public static Type
getPartitionColumnType(MTMVRelatedTableIf relatedTable, Strin
throw new AnalysisException("can not getPartitionColumnType by:" +
col);
}
+ /**
+ * The base partitions that a refresh of the given MV partitions resets,
per table the MV is
+ * partitioned by: every base partition the partition mapping names for
them.
+ */
+ public static Map<BaseTableInfo, Set<Long>> collectPctResetPartitionIds(
Review Comment:
[P2] Update the existing test after extracting this helper
`MTMVTaskTest.testCollectPctResetPartitionIdsSupportsMultiplePctTables`
still calls `Deencapsulation.invoke(task, "collectPctResetPartitionIds",
refreshContext, ...)` at lines 1643-1644. Removing the private task method
means reflection can no longer find it on `MTMVTask` or its superclasses, so
this enabled test now throws `IllegalArgumentException: No compatible method
found` before reaching its assertions. Update or move the test to call the new
utility with an explicit partition-mapping map, retaining its multi-table and
shared-partition assertions. If it stays in `MTMVTaskTest`, also allow the real
method through that fixture's `MTMVPartitionUtil` static mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
