xy720 commented on code in PR #16978:
URL: https://github.com/apache/doris/pull/16978#discussion_r1112986003
##########
be/src/runtime/types.cpp:
##########
@@ -270,6 +270,15 @@ TypeDescriptor::TypeDescriptor(const
google::protobuf::RepeatedPtrField<PTypeNod
}
}
+void TypeDescriptor::add_sub_type(TypeDescriptor&& sub_type, std::string&&
field_name,
+ bool&& is_nullable) {
+ children.emplace_back(sub_type);
+ if (!field_name.empty()) {
Review Comment:
Better use a new method add_field_name for field_name.
Because field_name is only used for struct type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
