cambyzju commented on code in PR #16978:
URL: https://github.com/apache/doris/pull/16978#discussion_r1112592300
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -607,21 +607,28 @@ TypeDescriptor OrcReader::_convert_to_doris_type(const
orc::Type* orc_type) {
case orc::TypeKind::TIMESTAMP_INSTANT:
return TypeDescriptor(PrimitiveType::TYPE_DATETIMEV2);
case orc::TypeKind::LIST: {
+ // Use Object PrimitiveType to construct TypeDescriptor also need init
containers_nulls with the default value of bool
TypeDescriptor list_type(PrimitiveType::TYPE_ARRAY);
list_type.children.emplace_back(_convert_to_doris_type(orc_type->getSubtype(0)));
Review Comment:
better add a function like:
`TypeDescriptor::add_sub_type(type, bool is_nullable = true);`
contains_nulls should be true as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
