github-actions[bot] commented on code in PR #69592:
URL: https://github.com/apache/doris/pull/69592#discussion_r4373692352
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/LocalTableValuedFunction.java:
##########
@@ -61,6 +61,8 @@ public class LocalTableValuedFunction extends
ExternalFileTableValuedFunction {
private boolean sharedStorage = false;
public LocalTableValuedFunction(Map<String, String> properties) throws
AnalysisException {
+ checkAccess();
Review Comment:
[P2] Adapt the Parquet metadata suite's LOCAL-glob assertions
`test_parquet_meta_tvf.groovy` still runs
`order_qt_parquet_file_metadata_local_glob` with
`file_path='${outFilePath}/*meta.parquet'` (lines 271–276).
`ParquetMetadataTableValuedFunction.expandSingleGlob` constructs
`LocalTableValuedFunction` for that local glob, so this new check throws `LOCAL
TVF is disabled` instead of returning the recorded count `3`; the suite aborts
before its later metadata checks. Its no-match glob case (lines 516–523) also
still expects `failed to glob`, which is no longer reachable. Adapt these two
dependent assertions to the disabled behavior while retaining the independent
literal-local and remote metadata checks. This is a separate consumer from the
already-fixed duplicate-output sink fixture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
