github-actions[bot] commented on code in PR #69343:
URL: https://github.com/apache/doris/pull/69343#discussion_r4346228259
##########
fe/pom.xml:
##########
@@ -437,7 +437,7 @@ under the License.
with the SAME paimon jar; a version mismatch silently breaks that
FE->BE
deserialization at runtime. These two MUST stay equal — do NOT
override
paimon.version per-module. -->
- <paimon.version>1.4.2</paimon.version>
+ <paimon.version>2.1.0</paimon.version>
Review Comment:
[P1] Handle nullable keys in MERGE match detection
The SDK bump makes `primary-key.nullable=true` tables readable/writable, but
Doris's changelog MERGE still detects a target row using `firstPrimaryKey IS
NOT NULL` (`ConnectorChangelogPlanBuilder.MergeBuilder.bindBranchLabel`). For a
target row `(NULL,20)`, `MERGE INTO t USING (SELECT NULL AS id, 99 AS v) s ON
t.id <=> s.id WHEN MATCHED THEN UPDATE SET v=s.v` joins successfully, then
produces `branch=IF(t.id IS NOT NULL,0,NULL)`; the subsequent `Filter(branch IS
NOT NULL)` discards it, so the statement succeeds without updating the row.
MATCHED DELETE has the same problem. Use a separate target-presence marker, or
reject MERGE on nullable-key tables until it is supported, and cover this with
a Doris SQL test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
