Gabriel39 commented on code in PR #69346:
URL: https://github.com/apache/doris/pull/69346#discussion_r4344896560
##########
be/src/format_v2/table/lance_reader.h:
##########
@@ -82,6 +82,14 @@ class LanceTableReader final : public TableReader {
std::string _snapshot_description() const;
Status _prepare_fts_query_context();
Status _open_scanner(const TFileRangeDesc& range);
+ struct RowIdPrefilter {
+ Status status;
+ // Empty selects no rows; nullopt keeps the provider's native filter
for a broad result.
+ std::optional<std::vector<uint64_t>> row_ids;
Review Comment:
Fixed in d3e3f1b0015. Both the in-flight collector and the query-local
cached allowlist now use DorisVector<uint64_t>, so buffer allocations
participate in query memory checks and accounting. The reader regression now
verifies retained accounting after reader closure, unchanged consumption on
cache hits, and release on cache destruction, flushing TLS accounting before
assertions. A focused harness executing the production collector/cache methods
also verifies cleanup on stop, broad-filter fallback, and allocation failure,
followed by an uncached retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
