Gabriel39 commented on code in PR #69346:
URL: https://github.com/apache/doris/pull/69346#discussion_r4344086151
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/LanceExternalSearchTableValuedFunction.java:
##########
@@ -108,6 +108,16 @@ protected
LanceExternalSearchTableValuedFunction(PreparedSearch prepared) {
this.offset = common.offset;
}
+ protected LanceExternalSearchTableValuedFunction(PreparedSearch prepared,
byte[] substraitFilter) {
+ this(prepared);
+ // Automatic rewrites must apply the original WHERE before choosing
search candidates.
+ searchRequest.setPrefilter(true);
+ if (substraitFilter.length > 0) {
+ searchRequest.setSearchFilter(new
TSearchFilter().setFormat(TSearchFilterFormat.SUBSTRAIT)
Review Comment:
Confirmed for old readers. Mixed-version/cloud smooth-upgrade compatibility
was explicitly excluded from this PR's requested scope. The PR description now
states that native search rewrites require BEs containing this reader change;
this PR does not add old-reader capability gating or rescheduling. The
incompatible-old-reader scenario is acknowledged, rather than claimed fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
