924060929 commented on code in PR #69299:
URL: https://github.com/apache/doris/pull/69299#discussion_r4321913153
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorMetadata.java:
##########
@@ -424,26 +438,52 @@ private String loadTableComment(ConnectorSession session,
String dbName, String
@Override
public Optional<ConnectorTableHandle> getTableHandle(
ConnectorSession session, String dbName, String tableName) {
+ IcebergTableHandle handle = new IcebergTableHandle(dbName, tableName);
+ if (IcebergStatementScope.hasReadTable(session, dbName, tableName)
+ || (tableCache != null &&
tableCache.contains(TableIdentifier.of(dbName, tableName)))) {
Review Comment:
Fixed in b44b384627e29c52d65bc56b4b5d00ffcb065e1e. Both CREATE-only
existence probes now use the existing live tableExists API, including the
post-create-failure IF NOT EXISTS race check. Cached/pinned handles remain
confined to query reads. Added ordinary CREATE and IF NOT EXISTS cases after an
external drop, plus a failed-create case proving a stale handle cannot turn the
error into a successful no-op. All 90 DDL routing tests passed; full FE build
and Checkstyle passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
