csun5285 opened a new pull request, #69191:
URL: https://github.com/apache/doris/pull/69191
### What problem does this PR solve?
Issue Number: None
Related PR: #69120 (master), #56079 (introduced the invalid default type)
Problem Summary: PR #56079 introduced `VecDateTimeValue::DEFAULT_VALUE` with
the compute-layer `TYPE_DATETIME` enum where the storage-layer `TimeType` was
required. The value is stored in a three-bit field, so it becomes an invalid
type and can serialize to an empty string. This PR uses valid time types and
defines separate `DATE_DEFAULT_VALUE` and `DATETIME_DEFAULT_VALUE` constants.
This is a backport of #69120 onto branch-4.2.
### Backport notes
The only conflict is
`be/test/exec/runtime_filter/runtime_filter_partition_pruner_test.cpp`: neither
that test nor `RuntimeFilterPartitionPruner` exists on branch-4.2, so the
test-side adaptation for it is dropped. The other 7 files apply unchanged, and
the resulting diff is byte-identical to the change on master.
### Release note
Fix legacy DATE/DATETIME default values so they carry valid time types and
serialize canonically instead of an empty string.
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test (targeted BE unit tests on the branch-4.2 Release build
are running; results will be posted as a comment)
- [x] Manual test: full `./build.sh --be` on branch-4.2 with this pick
applied succeeds with no compiler warnings or errors
- [ ] No need to test or manual test. Explain why <!-- At least one must
be included. -->
- Behavior changed:
- [x] Yes. Default DATE/DATETIME values now carry valid time types and
serialize canonically.
- Does this need documentation?
- [x] No.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
