github-actions[bot] commented on code in PR #16661:
URL: https://github.com/apache/doris/pull/16661#discussion_r1107942948
##########
be/src/vec/exec/format/csv/csv_reader.h:
##########
@@ -114,11 +134,24 @@ class CsvReader : public GenericReader {
int _value_separator_length;
int _line_delimiter_length;
bool _trim_double_quotes = false;
+ bool _trim_tailing_spaces_for_external_table_query = false;
IOContext* _io_ctx;
// save source text which have been splitted.
std::vector<Slice> _split_values;
+ // pair is (_field_start, len)
+ // because the _output_buf and _output_buf_pos may be change.
+ // we can not save (_output_buf+_output_buf_pos) only.
+ // We should save the offset from line_start (that is _field_start),
+ // so that when _output_buf and _output_buf_pos change
+ // we can use (line_start() + _field_start) to find the
+ // correct start of a field
+ std::vector<std::pair<int, int>> _fields_pos;
+
+ // std::unique_ptr<csv::CSVReader> _csv_reader;
+ csv::CSVReader::iterator _csv_row_iterator;
Review Comment:
warning: use of undeclared identifier 'csv' [clang-diagnostic-error]
```cpp
csv::CSVReader::iterator _csv_row_iterator;
^
```
##########
be/src/vec/exec/format/csv/csv_reader.h:
##########
@@ -114,11 +134,24 @@
int _value_separator_length;
int _line_delimiter_length;
bool _trim_double_quotes = false;
+ bool _trim_tailing_spaces_for_external_table_query = false;
IOContext* _io_ctx;
// save source text which have been splitted.
std::vector<Slice> _split_values;
+ // pair is (_field_start, len)
+ // because the _output_buf and _output_buf_pos may be change.
+ // we can not save (_output_buf+_output_buf_pos) only.
+ // We should save the offset from line_start (that is _field_start),
+ // so that when _output_buf and _output_buf_pos change
+ // we can use (line_start() + _field_start) to find the
+ // correct start of a field
+ std::vector<std::pair<int, int>> _fields_pos;
+
+ // std::unique_ptr<csv::CSVReader> _csv_reader;
+ csv::CSVReader::iterator _csv_row_iterator;
Review Comment:
warning: private field '_csv_row_iterator' is not used
[clang-diagnostic-unused-private-field]
```cpp
csv::CSVReader::iterator _csv_row_iterator;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
