github-actions[bot] commented on code in PR #16661: URL: https://github.com/apache/doris/pull/16661#discussion_r1105458194
########## be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h: ########## @@ -88,6 +104,25 @@ class NewPlainTextLineReader : public LineReader { size_t _current_offset; + std::string _value_delimiter; + size_t _value_delimiter_length; + bool _trim_tailing_spaces_for_external_table_query = false; + bool _trim_double_quotes = false; + + // point to the start of next field. + // this is an offset from line_start(). + size_t _field_start = 0; + size_t _non_space_offset = 0; + // point to the current position from line_start(). + // this is an offset from line_start() . + size_t _line_cur_pos = 0; + // point to the current pos of separator matching sequence. + // this is an offset from the start of value_delimiter. + size_t _value_delimiter_cur_pos = 0; Review Comment: warning: private field '_value_delimiter_cur_pos' is not used [clang-diagnostic-unused-private-field] ```cpp size_t _value_delimiter_cur_pos = 0; ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org