github-actions[bot] commented on code in PR #68631:
URL: https://github.com/apache/doris/pull/68631#discussion_r4134752120
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/WarmupSelectCommand.java:
##########
@@ -216,6 +216,12 @@ public void sendAggregatedBlackholeResults(Map<Long,
TQueryStatisticsResult> sta
executor.sendResultSet(resultSet);
}
+ @Override
+ public ShowResultSetMetaData getResultSetMetaData() {
+ // Unlike ordinary INSERT, warmup returns per-backend statistics
rather than OK.
+ return metaData;
Review Comment:
[P2] Preserve the WARM UP schema for empty sources. `WARM UP SELECT * FROM t
WHERE FALSE` becomes `PhysicalBlackholeSink -> PhysicalEmptyRelation`;
`InsertIntoTableCommand.runInternal` returns before registering the statistics
listener, and direct Flight execution emits one-column `StatusResult`. This
override still advertises six statistics columns to GetSchema and Prepare:
direct GetFlightInfo/DoGet returns a different schema, while prepared
GetFlightInfo expires the handle as schema drift. Make empty warmups emit the
statistics header too, or account for that fast return during schema discovery,
and cover this WHERE FALSE path in the Flight regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
