github-actions[bot] commented on code in PR #68385:
URL: https://github.com/apache/doris/pull/68385#discussion_r4131727472
##########
be/src/cloud/cloud_txn_delete_bitmap_cache.cpp:
##########
@@ -329,6 +350,7 @@ void
CloudTxnDeleteBitmapCache::remove_unused_tablet_txn_info(TTransactionId tra
erase(cache_key);
_txn_map.erase(txn_key);
}
+ _empty_rowset_markers.erase(txn_key);
Review Comment:
[P2] Keep the empty-rowset marker until local visibility succeeds.
`CloudTablet::try_make_committed_rs_visible_for_mow()` calls this cleanup from
an unconditional `Defer`, including when a version arrives out of order or
`create_empty_rowset_for_hole()` fails before the rowset is applied. This new
erase then removes the only marker; a later notification gets no rowset from
`get_rowset_and_delete_bitmap()` and cannot apply that empty version locally
until a full metadata sync repairs the hole. The make-visible task has multiple
workers, so out-of-order execution is reachable when the BE visibility feature
is enabled. Remove the marker only after successful application or when it is
proven obsolete, and cover failure/retry and out-of-order requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
