github-actions[bot] commented on code in PR #68385: URL: https://github.com/apache/doris/pull/68385#discussion_r4129530220
########## be/src/common/config.cpp: ########## @@ -857,14 +857,14 @@ DEFINE_mInt32(storage_flood_stage_usage_percent, "90"); // 90% DEFINE_mInt64(storage_flood_stage_left_capacity_bytes, "1073741824"); // 1GB // number of thread for flushing memtable per store DEFINE_mInt32(flush_thread_num_per_store, "6"); -// number of thread for flushing memtable per store, for high priority load task +// Deprecated compatibility setting; foreground load tasks share the normal flush pool. DEFINE_mInt32(high_priority_flush_thread_num_per_store, "6"); -// number of threads = min(flush_thread_num_per_store * num_store, -// max_flush_thread_num_per_cpu * num_cpu) -DEFINE_mInt32(max_flush_thread_num_per_cpu, "4"); +// Maximum shared foreground load threads per CPU (default 8). +// Without adaptive flushing, also capped by flush_thread_num_per_store * num_store. +DEFINE_mInt32(max_flush_thread_num_per_cpu, "8"); -// minimum flush threads per cpu when adaptive flush is enabled (default 0.5) -DEFINE_mDouble(min_flush_thread_num_per_cpu, "0.5"); +// Minimum shared foreground load threads per CPU when adaptive flushing is enabled (default 1). +DEFINE_mDouble(min_flush_thread_num_per_cpu, "1.0"); Review Comment: [P2] Keep the adaptive startup minimum bounded per workload group. This default feeds `WorkloadGroupInfo::parse_topic_info()` for every published group, and each `mf_<group>` pool attempts to start `min_flush_thread_num_per_cpu * CPU count` workers immediately. On a 64-CPU BE with 12 groups, those pools request 768 idle workers instead of 384 before any load; removing one global high-priority pool does not offset the per-group growth. The extra workers can exhaust thread or memory limits and interfere with other BE pools. Please retain the former group minimum or give group pools a separate bound, and cover multi-group creation. The existing max-setting comment concerns `LoadStreamMgr` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
