CalvinKirs commented on PR #68563: URL: https://github.com/apache/doris/pull/68563#issuecomment-5866875636
Local skill review completed at head: no Blocker, Major or Minor finding outstanding, 1 Nit. Full report: https://github.com/apache/doris/pull/68563#pullrequestreview-5336312955 Two rounds in the main session with the repo `code-review` skill, attested below. Round 1 read the whole diff at `4c4c3c8`. It raised one Minor: `start_palo()` had lost an unconditional `time.sleep(5)` that ran on every start, not only on the plugin path. `28385d5` restores it. It also raised one Nit, left open: `threat-model.md` still names `auditloader` (row 11 and decision M4). Round 2 re-read the diff at head and found nothing new. Evidence: a tree-wide grep finds no build, CI or script reference to the removed module; the `fe_plugins` reactor resolves with auditdemo, trino-converter and sparksql-converter; and `py_compile` passes on the edited `pytest/deploy` scripts. Clusters that already installed the plugin keep loading it from `plugin_dir` through `PluginMgr.replayLoadDynamicPlugin`. The remaining plugins were not compiled locally, and the deploy flow was not run. <!-- doris-repo-review:v1:begin --> ```yaml schema: doris-repo-review/v1 status: PASS pr: apache/doris#68563 commit: 28385d5ac4b397cc5a06876fc0e6679248d55856 base: 6cfe3656fbb0b1f273554b82e7a93ea84ef35c1b reviewed_at: 2026-09-28T17:08:34+08:00 reviewer: CalvinKirs model: claude-fable-5-1 effort: xhigh findings: {blocker: 0, major: 0, minor: 0, nit: 1} rounds: 2 converged: true ``` <!-- doris-repo-review:v1:end --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
