CalvinKirs opened a new pull request, #68563:
URL: https://github.com/apache/doris/pull/68563
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
`fe_plugins/auditloader` is the old standalone audit loader plugin, which
had to be built with `build-plugin.sh` and installed with `INSTALL PLUGIN`. FE
now ships a built-in audit loader
(`org.apache.doris.plugin.audit.AuditLoader`), registered by `PluginMgr` at
startup, which writes audit events into `__internal_schema.audit_log` and is
switched by the global variable `enable_audit_plugin`. Nothing in FE or the
build depends on the standalone copy any more, and it has drifted from the
built-in one. This PR removes the module and its entry in `fe_plugins/pom.xml`.
The legacy `pytest/deploy` scripts had an optional path that installed this
plugin. When `output/audit_loader/auditloader.zip` existed, they rendered
`plugin_auditload.conf`, unpacked the zip into the FE directory, created
`doris_audit_db__.doris_audit_tbl__` and ran `INSTALL PLUGIN`. No build
produces that zip, so the path never ran. This PR removes that path,
`plugin_auditload.conf`, and the `deploy_audit` parameter it threaded through
`prepare_palo_package()` and `start_palo()`.
### Release note
The standalone `auditloader` plugin source is removed from `fe_plugins/`.
Use the built-in audit loader instead: audit logs go to
`__internal_schema.audit_log`, controlled by the global variable
`enable_audit_plugin`.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- `mvn validate` in `fe_plugins/` lists auditdemo, trino-converter and
sparksql-converter as the remaining reactor modules. No other module references
auditloader.
- `python3 -m py_compile` passes on the four edited `pytest/deploy`
scripts. The deploy flow itself was not run.
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
