luwei16 commented on PR #68057:
URL: https://github.com/apache/doris/pull/68057#issuecomment-5694596177
Review conclusion: **PASS**.
- The PR stays focused on decoupling Row Binlog compaction from the CCR-only
switch across Cloud, non-Cloud producer, and local execution eligibility paths.
- CCR download, ingest, `enable_binlog()` / `enable_ccr_binlog()`,
transaction, and snapshot checks remain unchanged.
- Global and per-tablet automatic-compaction gates, local memory-pressure
pause, tablet role/state/path/init checks, lifecycle, locking, and task cleanup
remain intact.
- No protocol, persistence, storage-format, transaction, or FE/BE
compatibility change is introduced.
- Targeted unit tests cover the three removed dependencies plus negative
automatic-compaction and tablet-role behavior; the previously reported 48-test
related suite passed, along with format and static-analysis checks.
- One non-blocking minor remains: CCR-disabled deployments newly expose the
existing producer's idle full-tablet enumeration. The code proves extra polling
but does not establish material CPU/latency impact; scheduler redesign is not a
merge prerequisite for this focused fix.
The earlier major classification has been withdrawn, clarified in-thread,
and the thread is resolved. Three review rounds converged with no blocker or
major.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68057
commit: a97c1afbbaf2451a5cf11aa81dac70d8fa89aedb
base: 90f75bf67cca9d3cd7a77937e141f860807a8e45
reviewed_at: 2026-09-16T16:39:29+08:00
reviewer: luwei16
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 3
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
