luwei16 commented on code in PR #68057:
URL: https://github.com/apache/doris/pull/68057#discussion_r4024094878
##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -681,7 +681,7 @@ void
CloudStorageEngine::_binlog_compaction_tasks_producer_callback() {
int64_t interval = config::generate_compaction_tasks_interval_ms;
do {
int64_t cur_time = UnixMillis();
- if (config::enable_feature_binlog && !config::disable_auto_compaction)
{
+ if (!config::disable_auto_compaction) {
Review Comment:
Scope correction after a third review round: I withdraw the major/blocking
classification. The no-empty-backoff producer behavior is pre-existing; this PR
broadens its activation to CCR-disabled deployments, which is a valid but
currently unquantified performance concern. The inspected evidence does not
establish material CPU/latency impact sufficient for a major, and requiring a
manager-wide Row Binlog index would exceed the proportional scope of this
focused fix. I am retaining this only as a non-blocking minor/follow-up and
marking the PR PASS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
