csun5285 commented on code in PR #66774:
URL: https://github.com/apache/doris/pull/66774#discussion_r3782955909
##########
be/src/storage/segment/segment_writer.cpp:
##########
@@ -334,18 +333,6 @@ Status SegmentWriter::_create_writers(const
TabletSchemaSPtr& tablet_schema,
}
Status SegmentWriter::append_block(const Block* block, size_t row_pos, size_t
num_rows) {
- // Fixed partial update blocks arrive full-width, already filled by the
transform
- // chain; only the flexible mode still needs the vertical writer.
- if (_opts.rowset_ctx->partial_update_info &&
- _opts.rowset_ctx->partial_update_info->is_partial_update() &&
- _opts.write_type == DataWriteType::TYPE_DIRECT &&
- !_opts.rowset_ctx->is_transient_rowset_writer &&
- !_opts.rowset_ctx->partial_update_info->is_fixed_partial_update()) {
- return Status::NotSupported<false>(
- "SegmentWriter doesn't support flexible partial update, please
set "
Review Comment:
自然而然支持了灵活列更新在segment writer 写入
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
