csun5285 commented on code in PR #66774:
URL: https://github.com/apache/doris/pull/66774#discussion_r3782952676
##########
be/src/storage/transform/block_transform.cpp:
##########
@@ -199,18 +200,21 @@ BlockTransformChain build_transform_chain(const
RowsetWriterContext& context) {
const bool rebuild_row_store = context.write_type ==
DataWriteType::TYPE_DIRECT ||
context.write_type ==
DataWriteType::TYPE_SCHEMA_CHANGE;
if (is_partial_update_load) {
+ // A partial update load is always TYPE_DIRECT, so the row store is
+ // always rebuilt.
if (context.partial_update_info->is_fixed_partial_update()) {
stages.push_back(std::make_shared<FixedPartialUpdateFillStage>());
// The legacy fixed path parsed both provided and missing Variant
- // columns before rebuilding RowStore. A partial update load is
always
- // TYPE_DIRECT, so the row store is always rebuilt.
+ // columns before rebuilding RowStore.
stages.push_back(std::make_shared<VariantParseStage>());
stages.push_back(std::make_shared<RowStoreFillStage>());
- return BlockTransformChain {std::move(stages)};
+ } else {
+
stages.push_back(std::make_shared<FlexiblePartialUpdateFillStage>());
Review Comment:
这个和之前的行为一致
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
