sollhui commented on code in PR #64878:
URL: https://github.com/apache/doris/pull/64878#discussion_r3654168312
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/kafka/KafkaRoutineLoadJob.java:
##########
@@ -782,9 +782,12 @@ public void modifyProperties(AlterRoutineLoadCommand
command) throws UserExcepti
}
modifyPropertiesInternal(jobProperties, dataSourceProperties);
+ if (command.hasTargetTable()) {
+ tableId = command.getTargetTableId();
Review Comment:
[P1] Keep checkpoint reconstruction consistent with the switched target.
This assignment persists the new `tableId`, but `origStmt` still contains the
original CREATE properties. `RoutineLoadJob.gsonPostProcess()` reparses that
statement, substitutes the current table name, and validates the original
properties against it. For example: create the job on MoW table A with
`UPDATE_FIXED_COLUMNS`, alter the job to `UPSERT`, then switch to a non-MoW
OLAP table B. The live switch is valid under the current UPSERT mode, but an
image reload reparses `UPDATE_FIXED_COLUMNS` against B; validation fails and
the catch path marks the job `CANCELLED`. Please persist or reconstruct one
canonical effective definition, or update the canonical statement, and add a
full image round-trip test covering this sequence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
