github-actions[bot] commented on code in PR #64878:
URL: https://github.com/apache/doris/pull/64878#discussion_r3636543341
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/kafka/KafkaRoutineLoadJob.java:
##########
@@ -782,9 +782,12 @@ public void modifyProperties(AlterRoutineLoadCommand
command) throws UserExcepti
}
modifyPropertiesInternal(jobProperties, dataSourceProperties);
+ if (command.hasTargetTable()) {
+ tableId = command.getTargetTableId();
Review Comment:
[P1] Preserve Cloud progress for custom-only target switches. This combined
path passes non-null KafkaDataSourceProperties for FROM
KAFKA("property.client.id"="...") but no offsets; modifyPropertiesInternal()
still calls resetRLProgress with an empty partition_to_offset map, and
MetaService interprets that as deleting rl_progress_key. The live FE keeps its
local object, but a failover before the next task commit gets
ROUTINE_LOAD_PROGRESS_NOT_FOUND and can resume the new target from
follower-stale or default offsets. Skip the reset when the delta has no
explicit progress/source-identity change (or persist an atomic prepared
transition), and add a Cloud failover test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
