csun5285 commented on code in PR #65492:
URL: https://github.com/apache/doris/pull/65492#discussion_r3644336483
##########
be/src/storage/segment/segment_writer.cpp:
##########
@@ -1198,22 +1086,16 @@ void SegmentWriter::set_max_key(const Slice& key) {
_max_key.append(key.get_data(), key.get_size());
}
-void SegmentWriter::set_mow_context(std::shared_ptr<MowContext> mow_context) {
- _mow_context = mow_context;
-}
-
Status SegmentWriter::_generate_primary_key_index(
- const std::vector<const KeyCoder*>& primary_key_coders,
const std::vector<IOlapColumnDataAccessor*>& primary_key_columns,
IOlapColumnDataAccessor* seq_column, size_t num_rows, bool need_sort) {
if (!need_sort) { // mow table without cluster key
std::string last_key;
for (size_t pos = 0; pos < num_rows; pos++) {
- // use _key_coders
- std::string key = _full_encode_keys(primary_key_columns, pos);
+ std::string key = _key_encoder.full_encode(primary_key_columns,
pos);
_maybe_invalid_row_cache(key);
if (_tablet_schema->has_sequence_col()) {
- _encode_seq_column(seq_column, pos, &key);
+ _key_encoder.append_seq_suffix(&key, seq_column, pos);
Review Comment:
在key 里面吧 seq_column 加上，查询的时候：如果前面的key 一样的话，就顺利的比较seq 了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
