github-actions[bot] commented on code in PR #65633:
URL: https://github.com/apache/doris/pull/65633#discussion_r3585361481
##########
regression-test/suites/fault_injection_p0/test_incomplete_commit_info.groovy:
##########
@@ -39,9 +39,12 @@ suite("test_incomplete_commit_info", "nonConcurrent") {
`k12` string replace null comment "",
`k13` largeint(40) replace null comment ""
) engine=olap
- DISTRIBUTED BY HASH(`k1`) BUCKETS 5 properties("replication_num" =
"1")
+ DISTRIBUTED BY HASH(`k1`) BUCKETS 1 properties("replication_num" =
"1")
Review Comment:
This change makes the fault injection skip the only tablet in the load. With
`BUCKETS 1` and `replication_num=1`, `SHOW TABLETS` returns the sole tablet and
the debug point continues before adding its `TTabletCommitInfo`. That leaves
`commitInfos` empty, not incomplete. On the FE side `checkCommitStatus()`
builds `tableToPartition` only from the submitted commit infos, so an empty
list skips the replica quorum loop; `unprotectedCommitTransaction()` can then
commit with no `TableCommitInfo`, and the publish/finish checks also iterate
empty commit-info collections. This means the regression no longer validates
the intended "one tablet commit info is missing" failure and can return
success/publish-timeout instead of the asserted failure. Please keep at least
one non-target tablet commit info, or explicitly add/validate the
empty-commit-info failure path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
