shuke987 opened a new pull request, #65633:
URL: https://github.com/apache/doris/pull/65633

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: #53979
   
   Problem Summary:
   
   `test_incomplete_commit_info` expects stream load to fail after the debug 
point removes tablet commit information. The debug point previously skipped the 
first tablet independently in every `VNodeChannel`. With multiple buckets, 
those skipped entries could belong to different tablets, so every tablet could 
still retain the required replica quorum and the load would legally succeed.
   
   This change makes the injection deterministic:
   
   - the debug point skips commit info only for an explicitly supplied 
`tablet_id`;
   - the regression case uses one bucket, obtains its unique tablet id through 
`SHOW TABLETS`, and passes that id to the debug point;
   - the debug log records both the selected tablet and destination backend.
   
   Normal load behavior is unchanged when debug points are disabled. The debug 
point has only this one in-repository caller, which is updated in the same 
change.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test
       - [ ] Regression test
       - [ ] Unit Test
       - [x] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason
   
     Manual check:
   
     ```bash
     git diff origin/master...HEAD --check
     ```
   
     The targeted runtime regression test will be run after review because it 
requires a BE built from this patch.
   
   - Behavior changed:
       - [ ] No.
       - [x] Yes. The test-only debug point now requires an explicit 
`tablet_id` and no longer skips an arbitrary first tablet.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to