eldenmoon commented on code in PR #65561:
URL: https://github.com/apache/doris/pull/65561#discussion_r3575922985
##########
be/src/exprs/aggregate/aggregate_function_window.h:
##########
@@ -421,9 +421,14 @@ template <bool arg_is_nullable>
struct BaseValue : public Value<arg_is_nullable> {
public:
bool is_null() const { return this->_ptr == nullptr; }
- // because _ptr pointer to first_argument or third argument, so it's
difficult to cast ptr
- // so here will call virtual function
- StringRef get_value() const { return
this->_ptr->get_data_at(this->_offset); }
+
+ void insert_into(IColumn& to) const {
Review Comment:
这里让ColumnVariantV2实现get_data_at是不是就可以了， 然后revert 这里的代码修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
