eldenmoon commented on code in PR #65561:
URL: https://github.com/apache/doris/pull/65561#discussion_r3575917793
##########
be/src/exec/sort/heap_sorter.cpp:
##########
@@ -31,7 +31,7 @@ HeapSorter::HeapSorter(const VExprContextSPtrs&
ordering_expr_ctxs, RuntimeState
const RowDescriptor& row_desc, bool
have_runtime_predicate)
: Sorter(ordering_expr_ctxs, state, limit, offset, pool, is_asc_order,
nulls_first),
_heap_size(limit + offset),
- _state(MergeSorterState::create_unique(row_desc, offset)),
+ _state(MergeSorterState::create_unique(row_desc, offset, state)),
Review Comment:
尽可能不修改be/src/exec下的代码， 去掉 create_execution_column， 去掉session
variable控制，用BE的config控制
##########
be/src/exec/operator/aggregation_source_operator.cpp:
##########
@@ -23,6 +23,7 @@
#include "common/exception.h"
#include "core/column/column_fixed_length_object.h"
#include "exec/operator/operator.h"
+#include "exprs/variant_v2_execution.h"
Review Comment:
尽可能不修改be/src/exec下的代码， 去掉 create_execution_column， 去掉session
variable控制，用BE的config控制
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
