hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3465510672
##########
be/src/storage/tablet/tablet_meta.cpp:
##########
@@ -543,6 +543,7 @@ void TabletMeta::init_schema_from_thrift(const
TTabletSchema& tablet_schema,
DCHECK_EQ(index.columns.size(), 1);
if (iequal(tcolumn.column_name, index.columns[0])) {
column->set_is_bf_column(true);
+ has_bf_columns = index.index_type ==
TIndexType::type::BLOOMFILTER;
Review Comment:
My previous understanding of how tablet_meta handle `has_bf_columns` was
incorrect: The BE-side code in question is actually unnecessary. If a column on
the FE side has table properties for a Bloom filter (BF) or a named BF index,
it is marked as `is_bf_column`. This information is carried within the
`ColumnPB` inside `tablet_meta` after the metadata is pushed down; therefore,
relying solely on `column->is_bf_column()` is sufficient, and performing a
subsequent check for `BLOOMFILTER` within the indexes is redundant. The
BE-related code has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
