hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3449708281
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -3370,6 +3401,10 @@ private boolean processDropIndex(DropIndexOp
dropIndexOp, OlapTable olapTable, L
}
}
if (found == null) {
+ if (containsIgnoreCase(olapTable.getCopiedLegacyBfColumns(),
indexName)) {
Review Comment:
This function actually checks whether the user's DROP INDEX statement
intends to delete the 'bf' column defined in the table properties. It prevents
DROP INDEX from being misused with ALTER TABLE SET ("bloom_filter_column"=...)
and prompts the user for the correct deletion method. This is simply a more
precise exception throwing; in reality, this step can be omitted, and the
exception handling can be relied upon directly.
This validation check has been removed; the exception handling for `DROP
INDEX` on the BF index now relies solely on the "index xx does not exist"
message mentioned below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
