eldenmoon commented on code in PR #63970:
URL: https://github.com/apache/doris/pull/63970#discussion_r3338810085
##########
be/src/storage/segment/variant/variant_column_writer_impl.cpp:
##########
@@ -277,7 +290,29 @@ SubcolumnWritePlan build_subcolumn_write_plan(const
ColumnVariant& variant, size
return plan;
}
- build_doc_value_stats(variant, &plan.stats);
+ if (selected_paths != nullptr) {
Review Comment:
too many nested if else, need refactor and add code comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
