eldenmoon commented on code in PR #63970:
URL: https://github.com/apache/doris/pull/63970#discussion_r3338586586
##########
be/src/exec/common/variant_util.cpp:
##########
@@ -1998,6 +1997,10 @@ void parse_json_to_variant_impl(IColumn& column, const
char* src, size_t length,
FieldInfo field_info;
get_field_info(values[i], &field_info);
if (paths[i].empty()) {
+ if (!column_variant.enable_doc_mode() &&
Review Comment:
why need the if ？ add comment
##########
be/src/exec/common/variant_util.cpp:
##########
@@ -1998,6 +1997,10 @@ void parse_json_to_variant_impl(IColumn& column, const
char* src, size_t length,
FieldInfo field_info;
get_field_info(values[i], &field_info);
if (paths[i].empty()) {
+ if (!column_variant.enable_doc_mode() &&
Review Comment:
why need the if ？ add code comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
