pengxiangyu commented on code in PR #13865:
URL: https://github.com/apache/doris/pull/13865#discussion_r1015187159


##########
be/src/olap/rowset/segment_v2/segment.h:
##########
@@ -74,7 +74,8 @@ class Segment : public std::enable_shared_from_this<Segment> {
 
     uint32_t num_rows() const { return _footer.num_rows(); }
 
-    Status new_column_iterator(const TabletColumn& tablet_column, 
ColumnIterator** iter);
+    Status new_column_iterator(const TabletColumn& tablet_column, const 
IOContext& io_ctx,

Review Comment:
   init is called just in new_column_iterator()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to