yiguolei commented on code in PR #13865:
URL: https://github.com/apache/doris/pull/13865#discussion_r1013746447
##########
be/src/io/cache/dummy_file_cache.h:
##########
@@ -36,7 +36,7 @@ class DummyFileCache final : public FileCache {
Status close() override { return Status::OK(); }
- Status read_at(size_t offset, Slice result, size_t* bytes_read) override {
+ Status read_at(size_t offset, Slice result, size_t* bytes_read, const
IOContext* ctx) override {
Review Comment:
use reference not pointer.
Pointer is used as output parameter.
and please add ctx before bytes_read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
