gavinchou commented on code in PR #56175:
URL: https://github.com/apache/doris/pull/56175#discussion_r2363809234


##########
cloud/src/meta-store/keys.h:
##########
@@ -407,6 +410,8 @@ void job_tablet_key(const JobTabletKeyInfo& in, 
std::string* out);
 static inline std::string job_tablet_key(const JobTabletKeyInfo& in) { 
std::string s; job_tablet_key(in, &s); return s; }
 void rl_job_progress_key_info(const RLJobProgressKeyInfo& in, std::string* 
out);
 static inline std::string rl_job_progress_key_info(const RLJobProgressKeyInfo& 
in) { std::string s; rl_job_progress_key_info(in, &s); return s; }
+void streaming_job_meta_key_info(const StreamingJobMetaKeyInfo& in, 
std::string* out);
+static inline std::string streaming_job_meta_key_info(const 
StreamingJobMetaKeyInfo& in) { std::string s; streaming_job_meta_key_info(in, 
&s); return s; }

Review Comment:
   incorrect naming
   `streaming_job_meta_key_info` -> `streaming_job_key`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to