gavinchou commented on code in PR #56175:
URL: https://github.com/apache/doris/pull/56175#discussion_r2363803024
##########
cloud/src/meta-service/meta_service_txn.cpp:
##########
@@ -610,6 +610,77 @@ void put_routine_load_progress(MetaServiceCode& code,
std::string& msg,
<< " routine load new progress: " <<
new_progress_info.ShortDebugString();
}
+void update_streaming_job_meta(MetaServiceCode& code, std::string& msg,
+ const std::string& instance_id, const
CommitTxnRequest* request,
+ Transaction* txn, int64_t db_id) {
+ std::stringstream ss;
+ int64_t txn_id = request->txn_id();
+ if (!request->has_commit_attachment()) {
+ code = MetaServiceCode::INVALID_ARGUMENT;
+ ss << "missing commit attachment, db_id=" << db_id << " txn_id=" <<
txn_id;
+ msg = ss.str();
+ return;
+ }
+ TxnCommitAttachmentPB txn_commit_attachment = request->commit_attachment();
+ StreamingTaskCommitAttachmentPB commit_attachment =
+ txn_commit_attachment.streaming_task_txn_commit_attachment();
+ int64_t job_id = commit_attachment.job_id();
+
+ std::string streaming_meta_key;
+ std::string streaming_meta_val;
+ bool prev_meta_existed = true;
+ StreamingJobMetaKeyInfo streaming_meta_key_info {instance_id, db_id,
job_id};
+ streaming_job_meta_key_info(streaming_meta_key_info, &streaming_meta_key);
Review Comment:
use the form
`streaming_meta_key = streaming_job_meta_key_info(streaming_meta_key_info);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
