englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r951262636
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/AbstractPhysicalJoin.java:
##########
@@ -78,11 +90,27 @@ public boolean equals(Object o) {
return false;
}
AbstractPhysicalJoin that = (AbstractPhysicalJoin) o;
- return joinType == that.joinType && Objects.equals(condition,
that.condition);
+ return joinType == that.joinType && Objects.equals(otherJoinCondition,
that.otherJoinCondition);
Review Comment:
if there is hashJoinConjuncts like t1.x=t2.x, why choose NLJ, not hash join?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
