morrySnow commented on code in PR #11812: URL: https://github.com/apache/doris/pull/11812#discussion_r951035623
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/AbstractPhysicalJoin.java: ########## @@ -78,11 +90,27 @@ public boolean equals(Object o) { return false; } AbstractPhysicalJoin that = (AbstractPhysicalJoin) o; - return joinType == that.joinType && Objects.equals(condition, that.condition); + return joinType == that.joinType && Objects.equals(otherJoinCondition, that.otherJoinCondition); Review Comment: in nereids, NLJ could do join with hashJoinConjuncts, currently we do not do that just because BE could not execute it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org