[GitHub] [doris] platoneko commented on a diff in pull request #11450: [feature](cold_on_s3) Show remote data usage via SHOW BACKENDS and SHOW TABLETS statements

[GitBox]

platoneko commented on code in PR #11450:
URL: https://github.com/apache/doris/pull/11450#discussion_r950703910


##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/ReplicasProcNode.java:
##########
@@ -33,12 +33,10 @@
  * show replicas' detail info within a tablet
  */
 public class ReplicasProcNode implements ProcNodeInterface {
-    public static final ImmutableList<String> TITLE_NAMES = new 
ImmutableList.Builder<String>()
-            .add("ReplicaId").add("BackendId").add("Version")
-            .add("LstSuccessVersion").add("LstFailedVersion")
-            
.add("LstFailedTime").add("SchemaHash").add("DataSize").add("RowCount").add("State")
-            
.add("IsBad").add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus")
-            .build();
+    public static final ImmutableList<String> TITLE_NAMES = new 
ImmutableList.Builder<String>().add("ReplicaId")
+            
.add("BackendId").add("Version").add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime")
+            
.add("SchemaHash").add("LocalDataSize").add("RowCount").add("State").add("IsBad")
+            
.add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus").add("RemoteDataSize").build();

Review Comment:
   done



##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/TabletsProcDir.java:
##########
@@ -45,9 +45,9 @@ public class TabletsProcDir implements ProcDirInterface {
     public static final ImmutableList<String> TITLE_NAMES = new 
ImmutableList.Builder<String>()
             
.add("TabletId").add("ReplicaId").add("BackendId").add("SchemaHash").add("Version")
             
.add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime")
-            .add("DataSize").add("RowCount").add("State")
+            .add("LocalDataSize").add("RowCount").add("State")
             .add("LstConsistencyCheckTime").add("CheckVersion")
-            
.add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus")
+            
.add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus").add("RemoteDataSize")

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org