platoneko commented on code in PR #11450:
URL: https://github.com/apache/doris/pull/11450#discussion_r950681322
##########
be/src/io/fs/s3_file_system.cpp:
##########
@@ -141,7 +141,7 @@ Status S3FileSystem::open_file(const Path& path,
FileReaderSPtr* reader) {
RETURN_IF_ERROR(file_size(path, &fsize));
auto key = get_key(path);
auto fs_path = Path(_s3_conf.endpoint) / _s3_conf.bucket / key;
- *reader = std::make_unique<S3FileReader>(std::move(fs_path), fsize,
std::move(key),
+ *reader = std::make_shared<S3FileReader>(std::move(fs_path), fsize,
std::move(key),
Review Comment:
This is a typo(not bug) fix, as function signature is
`S3FileSystem::open_file(const Path& path, FileReaderSPtr* reader)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
